Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oshmem: Add Non-blocking Remote Memory Access Routines #1455

Merged
merged 8 commits into from
Mar 22, 2016
Merged

oshmem: Add Non-blocking Remote Memory Access Routines #1455

merged 8 commits into from
Mar 22, 2016

Conversation

igor-ivanov
Copy link
Member

openshmem spec v1.3 decalres new api non-blocking functions
This PR adds support of these api.

@yosefe could you look at spml/ucx component
@alex-mikheev could you check spml/ikrit and spml/yoda component
@jsquyres please check in general

@lanl-ompi
Copy link
Contributor

Test FAILed.

@hppritcha
Copy link
Member

bot:retest

@hppritcha
Copy link
Member

@igor-ivanov would you mind squashing this down to fewer commits?

@lanl-ompi
Copy link
Contributor

Test FAILed.

@hppritcha
Copy link
Member

The LANL bot is having jenkins issues. Please ignore unless the pr is rebased or new commits are added.

@igor-ivanov
Copy link
Member Author

@hppritcha technically I can push single commit but personally I prefer to review set of separate commits. It helps track a logic of changes. Let me know if you insist.
mellanox jenkins failure relates pmix and ucx valgrind issue that I noticed in recent PRs too.

@mike-dubman
Copy link
Member

bot:retest

@lanl-ompi
Copy link
Contributor

Test FAILed.

@jsquyres
Copy link
Member

@igor-ivanov If you have good rationale for having this many commits, no problem (and it sounds like you do). We just ask because we still have some git newbies who end up pushing all their intermediate commits to a pull request. On this PR, it sounds like this was not the case. Sorry for the noise...

@mike-dubman
Copy link
Member

bot:retest

@mike-dubman
Copy link
Member

@yosefe , @jladd-mlnx - please review

@lanl-ompi
Copy link
Contributor

Test FAILed.

2 similar comments
@lanl-ompi
Copy link
Contributor

Test FAILed.

@lanl-ompi
Copy link
Contributor

Test FAILed.

@lanl-ompi
Copy link
Contributor

Test FAILed.

2 similar comments
@lanl-ompi
Copy link
Contributor

Test FAILed.

@lanl-ompi
Copy link
Contributor

Test FAILed.

@yosefe
Copy link
Contributor

yosefe commented Mar 21, 2016

ucx part looks good.
what about spml/ikrit put?

@mike-dubman
Copy link
Member

@yosefe - put_nb:

https://github.com/igor-ivanov/ompi/blob/pr/oshmem-v1.3/oshmem/mca/spml/ikrit/spml_ikrit.c#L1305

@mike-dubman
Copy link
Member

👍

mike-dubman added a commit that referenced this pull request Mar 22, 2016
@mike-dubman
Merge pull request #1455 from igor-ivanov/pr/oshmem-v1.3
7483a66 
oshmem: Add Non-blocking Remote Memory Access Routines
@mike-dubman mike-dubman merged commit 7483a66 into open-mpi:master Mar 22, 2016
@mike-dubman
Copy link
Member

@igor-ivanov - please pr it into v2.x

@igor-ivanov igor-ivanov mentioned this pull request Mar 22, 2016
Closed
@artpol84 artpol84 mentioned this pull request Sep 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@igor-ivanov @lanl-ompi @hppritcha @mike-dubman @jsquyres @yosefe