Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configury: fix configure --disable-mpi-cxx when no C++ compiler is av… #1860

Closed

Conversation

ggouaillardet
Copy link
Contributor

…ailable/working

note:
if GNU C compiler is used but no GNU C++ compiler is available, then
CPPFLAGS='-x c'
must be added to the configure command line

…ailable/working

note:
if GNU C compiler is used but no GNU C++ compiler is available, then
CPPFLAGS='-x c'
must be added to the configure command line
@ggouaillardet
Copy link
Contributor Author

@jsquyres could you please have a look at it ?
if you build Open MPI on OSX with FreePGI, two issues remain

  • libtool pass -flat_namespace to the linker, it works fine with gcc, but pgcc expects -Wl,-flat_namespace
    I made a simple proof of concept (patch ltmain.sh, smilitary to what was done for NAG)
  • atomic prototypes are missing static inline which ends up with many symbols defined in multiple places, and link fails. I tried to understand the logic, but I could not get it all. some macro explicitly reference GCC, and that is wrong here. @hjelmn can you please have a look at it too ?

@@ -198,7 +198,8 @@ AC_DEFUN([OPAL_INTL_POSIX_THREADS_PLAIN_CXX], [
#
# C++ compiler
#
if test "$opal_pthread_cxx_success" = "0"; then
if test "$opal_pthread_cxx_success" = "0" && \
test "$WANT_MPI_CXX_SUPPORT" -eq; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing RHS 1.

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Signed-off-by line to this PR's commit.

@bwbarrett
Copy link
Member

@ggouaillardet, Can you either update or close this PR?

@ggouaillardet
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants