Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to shmem #1867

Merged
merged 2 commits into from
Jul 13, 2016
Merged

Fixes to shmem #1867

merged 2 commits into from
Jul 13, 2016

Conversation

hpcraink
Copy link
Member

Dear @jladd-mlnx and @miked-mellanox ,
could You please review this PR?

The fix to oshmem/shmem/fortran/shmem_put_f.c has been in since the earliest logs of git's repo: I see df7654e

AFAICT there are no other missing MCA_SPML_CALL and MCA_ATOMIC_CALL.

hpcraink added 2 commits July 13, 2016 11:23
provides a wrong input value, like "runtime"
(which works for MPI, but not for OSHMEM)
@mike-dubman
Copy link
Member

👍

@jsquyres jsquyres added the bug label Jul 13, 2016
@jsquyres jsquyres added this to the v2.0.1 milestone Jul 13, 2016
@jsquyres jsquyres merged commit 0d1afba into open-mpi:master Jul 13, 2016
@jsquyres
Copy link
Member

@hpcraink @miked-mellanox @jladd-mlnx Can someone file a corresponding PR for v2.0.1? Thanks!

@karasevb
Copy link
Member

@hppritcha @jsquyres
We are considering to PR this to ompi-release to be able to PR #1883 on top of it.

It seems like portion of this PR depends on open-mpi/ompi-release#1041 that is targeted for v2.1.0 while this one is set for v2.0.1 milestone.
Does that mean that we want to defer this PR and #1883 till v2.1.0 too?

@artpol84
Copy link
Contributor

artpol84 commented Aug 4, 2016

@hppritcha @jsquyres @jladd-mlnx @miked-mellanox Any thoughts?

@jsquyres
Copy link
Member

jsquyres commented Aug 4, 2016

Thanks for the ping; sorry for the delay in replying.

My $0.02:

and PR them accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants