Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coll/libnbc: Work around for non-uniform data types in ibcast #2330

Merged
merged 1 commit into from
Nov 5, 2016

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Nov 1, 2016

  • If (legal) non-uniform data type signatures are used in ibcast
    then the chosen algorithm may fail on the request, and worst case
    it could produce wrong answers.
  • Add an MCA parameter that, by default, protects the user from this
    scenario. If the user really wants to use it then they have to
    'opt-in' by setting the following parameter to false:
    • -mca coll_libnbc_ibcast_skip_dt_decision f
  • Once the following Issues are resolved then this parameter can
    be removed.

 * If (legal) non-uniform data type signatures are used in ibcast
   then the chosen algorithm may fail on the request, and worst case
   it could produce wrong answers.
 * Add an MCA parameter that, by default, protects the user from this
   scenario. If the user really wants to use it then they have to
   'opt-in' by setting the following parameter to false:
   - `-mca coll_libnbc_ibcast_skip_dt_decision f`
 * Once the following Issues are resolved then this parameter can
   be removed.
   - open-mpi#2256
   - open-mpi#1763

Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@hppritcha
Copy link
Member

bot:lanl:retest

@hppritcha
Copy link
Member

@jsquyres ready to go.

@jsquyres jsquyres merged commit f11b0c7 into open-mpi:master Nov 5, 2016
@jjhursey jjhursey deleted the topic/ibcast-non-uniform-dt-wa branch November 7, 2016 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants