Add multithreading support in PML UCX framework. #3168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinzhao3
force-pushed
the
topic/ucx-mt-support
branch
from
f7ca4d3 to
2aea543
Compare
xinzhao3
force-pushed
the
topic/ucx-mt-support
branch
2 times, most recently
from
5c07acd to
d863295
Compare
yosefe
reviewed
Mar 16, 2017
Contributor
yosefe
left a comment
yosefe
left a comment
There was a problem hiding this comment.
looks good, pls add error messages
| attr.field_mask = UCP_WORKER_ATTR_FIELD_THREAD_MODE; | ||
| status = ucp_worker_query(ompi_pml_ucx.ucp_worker, &attr); | ||
| if (UCS_OK != status) { | ||
| ucp_worker_destroy(ompi_pml_ucx.ucp_worker); |
Contributor
There was a problem hiding this comment.
pls add PML_UCX_ERROR message
| if (ompi_mpi_thread_multiple && attr.thread_mode != UCS_THREAD_MODE_MULTI) { | ||
| /* UCX does not support multithreading, disqualify current PML for now */ | ||
| /* TODO: we should let OMPI to fallback to THREAD_SINGLE mode */ | ||
| ucp_worker_destroy(ompi_pml_ucx.ucp_worker); |
Contributor
There was a problem hiding this comment.
pls add PML_UCX_ERROR message
xinzhao3
force-pushed
the
topic/ucx-mt-support
branch
from
d863295 to
dc86874
Compare
Signed-off-by: Xin Zhao <xinz@mellanox.com>
xinzhao3
force-pushed
the
topic/ucx-mt-support
branch
from
dc86874 to
6a99c60
Compare
Member
|
@yosefe please check off on the review if its ready to go. |
yosefe
approved these changes
Mar 20, 2017
Member
|
@bwbarrett good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.