configury: add portals4 include path to osc-monitoring component build #4521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
reviewed
Nov 21, 2017
ompi/mca/osc/monitoring/configure.m4
Outdated
| # substitute in the things needed to build portals4 | ||
| AC_SUBST([osc_monitoring_portals4_CPPFLAGS]) | ||
| AC_SUBST([osc_monitoring_portals4_LDFLAGS]) | ||
| AC_SUBST([osc_monitoring_portals4_LIBS]) |
There was a problem hiding this comment.
Doesn't look like the LDFLAGS and LIBS values are used.
Signed-off-by: Todd Kordenbrock <thkgcode@gmail.com>
Signed-off-by: Todd Kordenbrock <thkgcode@gmail.com>
tkordenbrock
force-pushed
the
topic/master/osc.monitoring.portals4.build.failure
branch
from
41410c1 to
cba8b7f
Compare
|
We do not need to interact with the other OSC modules. We are working on a fix. |
|
@jsquyres PR updated to remove unused variables. |
|
@bosilca So you are going to take out all the Portals4 references? |
|
@tkordenbrock yes all references to other OSC components. |
|
@bosilca So should this PR be closed / replaced by a different PR? |
|
A more generic approach is under development in #4527 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The osc-monitoring component didn't add the Portals4 include directory to AM_CPPFLAGS which causes a build failure if Portals4 is installed in a location that isn't in the compiler's default search path.
The PR clarifies the OPAL_CHECK_PORTALS4() prefix name, exports the Portals4 variables and adds the Portals4 CPPFLAGS to AM_CPPFLAGS.
Signed-off-by: Todd Kordenbrock thkgcode@gmail.com
@bosilca @jsquyres Please review.