-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fortran: Fix PMPI interface bugs in mpi_f08 module #4667
Conversation
It was removed from only `mpi` as a bug fix in db41d74. Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com>
They were incorrectly changed to subroutines in only `pmpi` in 258d1aa. Strictly speaking, this change involves binary incompatibility. But nobody used these subroutines and nobody will be affected because these subroutines were useless (didn't return a calculated value). Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com>
It was changed to use `C_PTR` in only `mpi` in fc69c0b. Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com>
It is incorrectly typed as `MPI_Comm` in only `pmpi` in 24f7bd3. Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com>
This change makes comparison of `mpi-f08-interfaces.F90` and `pmpi-f08-interfaces.F90` easier. Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the ABI impacts of this change (if any, I suck at Fortran)?
@bwbarrett It breaks ABI for This is worth a note in NEWS, though. |
@bwbarrett @jsquyres My commit message d4fc404 explains it.
Is it OK to merge this change to release branches (v2.0, v2.1, v3.0, v3.1)? The NEWS item will be something like this:
|
@kawashima-fj, yes, I think we should merge to the impacted release branches (although v2.0.x is dead, so don't worry about that branch). |
This PR brings bug fixes which were cared in
MPI_
interface but were not cared inPMPI_
interfaces of the Fortranmpi_f08
module.As the result,
ompi/mpi/fortran/use-mpi-f08/mod/pmpi-f08-interfaces.F90
withsed -e s/PMPI_/MPI_/g -e s/pmpi_/mpi_/g
becomes same asompi/mpi/fortran/use-mpi-f08/mod/mpi-f08-interfaces.F90
except copyright statements.@jsquyres, you changed
PMPI_Aint_add_f08
andPMPI_Aint_diff_f08
to subroutines from functions in your 258d1aa. I supposed it was an unintentional change and I reverted them to functions in my d4fc404. Could you confirm it just in case?Better fix is generating
pmpi-*
files frommpi-*
files. I remain it as a future work.I'll create PRs for release branches to handle this PR and #4659.
NEWS: Correct PMPI_Aint_{add|diff} to be functions (not subroutines) in the Fortran mpi_f08 module.