Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.x: configury: Make more robust in finding NAG Fortran Compiler #4879

Merged

Conversation

jsquyres
Copy link
Member

@jsquyres jsquyres commented Mar 5, 2018

The NAG Fortran check only matched "nagfor" exactly, and failed if a
path to nagfor was provided. Also change "-pthread" into
"-Wl,-pthread".

Signed-off-by: Themos Tsikas themos.tsikas@nag.co.uk
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit a8fc30f)

@hppritcha This can slot in whatever v2.1.x release we want -- it is not absolutely needed for v2.1.3. OTOH, it's a pretty trivial update (it's not obvious from the github rendering, but it's a 1-character change).

FTI @ThemosTsikas

@jsquyres jsquyres added the bug label Mar 5, 2018
@jsquyres jsquyres added this to the v2.1.3 milestone Mar 5, 2018
@jsquyres jsquyres requested a review from ggouaillardet March 5, 2018 19:16
@hppritcha hppritcha modified the milestones: v2.1.3, v2.1.4 Mar 15, 2018
The NAG Fortran check only matched "nagfor" exactly, and failed if a
path to nagfor was provided.  Also change "-pthread" into
"-Wl,-pthread".

Signed-off-by: Themos Tsikas <themos.tsikas@nag.co.uk>
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
(cherry picked from commit a8fc30f)
@jsquyres jsquyres force-pushed the pr/v2.x/nag-fortran-configury-update branch from d411168 to 43298b5 Compare March 26, 2018 19:33
@hppritcha hppritcha added the NEWS label Mar 26, 2018
@jsquyres jsquyres merged commit b033dec into open-mpi:v2.x Mar 26, 2018
@jsquyres jsquyres deleted the pr/v2.x/nag-fortran-configury-update branch March 26, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants