btl/vader: fix fast box support for 32-bit architectures #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32-bit architectures loads/stores of fast box headers may take multiple instructions. This can lead to a data race between the sender/receiver when reading/writing the sequence number. This can lead to a situation where the receiver could process incomplete data. To fix the issue this commit re-orders the fast box header to put the sequence number and the tag in the same 32-bits to ensure they are always loaded/stored together. Fixes open-mpi#473 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Closed
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
|
This commit will be ready to merge once I finish performance tests. |
|
Excuse the naive question, but does reordering items in the struct break ABI? |
|
Since it is internal to Open MPI it has no impact on ABI. |
hjelmn
added a commit
that referenced
this pull request
Mar 31, 2015
btl/vader: fix fast box support for 32-bit architectures
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
…time_check btl/openib: remove OFED version runtime check when XRC is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32-bit architectures loads/stores of fast box headers may take
multiple instructions. This can lead to a data race between the
sender/receiver when reading/writing the sequence number. This can
lead to a situation where the receiver could process incomplete
data. To fix the issue this commit re-orders the fast box header to
put the sequence number and the tag in the same 32-bits to ensure they
are always loaded/stored together.
Fixes #473
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov