OMPI/OSC/UCX: set priority to 0. #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can put this straight to v3.1.x. I wouldn't necessarily bother with master. Except to add the parameter. That should have been in there originally. No osc component should have a hard-coded priority. |
|
BTW, you are missing the mca_base_component_var_register to register the priority with the MCA. |
|
I disagree with @hjelmn on this one. I'd rather see it in master and then move to 3.1. That way, we're positive we've fixed the core issues before we change priority in master. Less chance of screwing up 4.0 the same way. |
Signed-off-by: Xin Zhao <xinz@mellanox.com>
|
@hjelmn @bwbarrett could you review again? I can create another PR on 3.1.x once this one looks good. |
|
@xinzhao3 Thank you, looks good now. Once this passes CI please merge and open the v3.1.x PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.