-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow run-as-root if 2 envars are set #5597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per suggestion by @bangerth, allow mpirun to execute as root if two envars are set to specific values Per conversation with @jsquyres, name the envars OMPI_ALLOW_RUN_AS_ROOT and OMPI_ALLOW_RUN_AS_ROOT_CONFIRM Fixes #4451 Signed-off-by: Ralph Castain <rhc@open-mpi.org> Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
approved these changes
Aug 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhc54 I added more text to the man page.
Should this part be changed as well?: ompi/orte/tools/orterun/orterun.c Lines 144 to 160 in ae1f7e0
|
simonbyrne
added a commit
to simonbyrne/ompi
that referenced
this pull request
Aug 12, 2019
I found that I needed to apply the same change as open-mpi#5597 to orterun.c for the environment variables to work correctly.
simonbyrne
added a commit
to simonbyrne/ompi
that referenced
this pull request
Aug 13, 2019
I found that I needed to apply the same change as open-mpi#5597 to orterun.c for the environment variables to work correctly. Signed-off-by: Simon Byrne <simonbyrne@gmail.com>
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 19, 2019
I found that I needed to apply the same change as open-mpi#5597 to orterun.c for the environment variables to work correctly. Signed-off-by: Simon Byrne <simonbyrne@gmail.com> (cherry picked from commit 9c8671c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per suggestion by @bangerth, allow mpirun to execute as root if two
envars are set to specific values
Per conversation with @jsquyres, name the envars OMPI_ALLOW_RUN_AS_ROOT
and OMPI_ALLOW_RUN_AS_ROOT_CONFIRM
Fixes #4451
Signed-off-by: Ralph Castain rhc@open-mpi.org