Always use same IP address for module and modex #5938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, a btl tcp module is associated with exactly one IP address (IPv4 or IPv6). There's no need to reserve space for both an IPv4 and IPv6 address in the module structure, since the module will only be associated with one or the other. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bosilca
reviewed
Oct 17, 2018
Simplify selection of the address to publish for a given BTL TCP module in the module exchange code. Rather than looping through all IP addresses associated with a node, looking for one that matches the kindex of a module, loop over the modules and use the address stored in the module structure. This also happens to be the address that the source will use to bind() in a connect() call, so this should eliminate any confusion (read: bugs) when an interface has multiple IPs associated with it. Refs open-mpi#5818 Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
force-pushed
the
bugfix/tcp-multi-address
branch
from
18de53f to
457f058
Compare
|
@bosilca fixed the address family option, which was tested on a platform with mixed IPv4 and IPv6 addresses. Ran out of time to implement the "use the address specified in the if_include / if_exclude" design. I don't think it's a huge design change (change tcp_create to take a sockaddr_storage instead of a kindex), but pulling apart the spilt_and_resolve is kind of going to suck. |
|
bot:ibm:retest |
bosilca
reviewed
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two patches that end up with simplifying the modex send so that we're not racy in a multi-IP per NIC design. We were already storing a source address in the local BTL, for use to bind() and force the source address to be known to us. With this patch, we guarantee that the address we use for bind() is the same we publish in the modex.
This should help with #5818.