OSHMEM/AMO: added int/uint/32/64 atomics calls - v4.0 #6110

hoopoepg · 2018-11-26T07:56:44Z

added int/uint/32/64 atomics calls
added SHMEM_SYNC_SIZE macro

backport from #6096

Signed-off-by: Sergey Oblomov sergeyo@mellanox.com
(cherry picked from commit 4c071da)

- added int/uint/32/64 atomics calls - added SHMEM_SYNC_SIZE macro Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com> (cherry picked from commit 4c071da)

gpaulsen · 2018-11-26T20:29:49Z

Lets discuss on Nov 27 web-ex call.

xinzhao3 · 2018-11-30T19:08:29Z

We confirm that this PR will not break the backward compatibility.

gpaulsen · 2018-11-30T20:00:04Z

@xinzhao3 can you please review? If not please assign someone else.

xinzhao3 · 2018-11-30T20:20:42Z

reviewing it now

xinzhao3 · 2018-11-30T20:37:40Z

oshmem/include/pshmem.h

+OSHMEM_DECLSPEC void pshmem_int32_atomic_and(int32_t *target, int32_t value, int pe);
+OSHMEM_DECLSPEC void pshmem_int64_atomic_and(int64_t *target, int64_t value, int pe);
+OSHMEM_DECLSPEC void pshmem_uint32_atomic_and(uint32_t *target, uint32_t value, int pe);
+OSHMEM_DECLSPEC void pshmem_uint64_atomic_and(uint64_t *target, uint64_t value, int pe);


should add int32/64, uint32/64 to C11 macro?

no - it failed to compile due to datatype conflicts

xinzhao3 · 2018-11-30T20:38:22Z

oshmem/include/pshmem.h

+OSHMEM_DECLSPEC void pshmem_int32_atomic_or(int32_t *target, int32_t value, int pe);
+OSHMEM_DECLSPEC void pshmem_int64_atomic_or(int64_t *target, int64_t value, int pe);
+OSHMEM_DECLSPEC void pshmem_uint32_atomic_or(uint32_t *target, uint32_t value, int pe);
+OSHMEM_DECLSPEC void pshmem_uint64_atomic_or(uint64_t *target, uint64_t value, int pe);


should add int32/64, uint32/64 to C11 macro?

xinzhao3 · 2018-11-30T20:38:38Z

oshmem/include/pshmem.h

+OSHMEM_DECLSPEC void pshmem_int32_atomic_xor(int32_t *target, int32_t value, int pe);
+OSHMEM_DECLSPEC void pshmem_int64_atomic_xor(int64_t *target, int64_t value, int pe);
+OSHMEM_DECLSPEC void pshmem_uint32_atomic_xor(uint32_t *target, uint32_t value, int pe);
+OSHMEM_DECLSPEC void pshmem_uint64_atomic_xor(uint64_t *target, uint64_t value, int pe);


should add int32/64, uint32/64 to C11 macro?

xinzhao3 · 2018-11-30T20:39:25Z

oshmem/include/pshmem.h

+OSHMEM_DECLSPEC  void pshmem_uint32_wait_until(volatile uint32_t *addr, int cmp, uint32_t value);
+OSHMEM_DECLSPEC  void pshmem_uint64_wait_until(volatile uint64_t *addr, int cmp, uint64_t value);
+OSHMEM_DECLSPEC  void pshmem_size_wait_until(volatile size_t *addr, int cmp, size_t value);
+OSHMEM_DECLSPEC  void pshmem_ptrdiff_wait_until(volatile ptrdiff_t *addr, int cmp, ptrdiff_t value);


should add int32/64, uint32/64, size, ptrdiff to C11 macro?

xinzhao3 · 2018-11-30T20:39:43Z

oshmem/include/pshmem.h

+OSHMEM_DECLSPEC  int pshmem_uint32_test(volatile uint32_t *addr, int cmp, uint32_t value);
+OSHMEM_DECLSPEC  int pshmem_uint64_test(volatile uint64_t *addr, int cmp, uint64_t value);
+OSHMEM_DECLSPEC  int pshmem_size_test(volatile size_t *addr, int cmp, size_t value);
+OSHMEM_DECLSPEC  int pshmem_ptrdiff_test(volatile ptrdiff_t *addr, int cmp, ptrdiff_t value);


should add int32/64, uint32/64, size, ptrdiff to C11 macro?

xinzhao3 · 2018-11-30T20:44:12Z

oshmem/include/shmem.h.in

+OSHMEM_DECLSPEC int32_t shmem_ctx_int32_atomic_fetch_xor(shmem_ctx_t ctx, int32_t *target, int32_t value, int pe);
+OSHMEM_DECLSPEC int64_t shmem_ctx_int64_atomic_fetch_xor(shmem_ctx_t ctx, int64_t *target, int64_t value, int pe);
+OSHMEM_DECLSPEC uint32_t shmem_ctx_uint32_atomic_fetch_xor(shmem_ctx_t ctx, uint32_t *target, uint32_t value, int pe);
+OSHMEM_DECLSPEC uint64_t shmem_ctx_uint64_atomic_fetch_xor(shmem_ctx_t ctx, uint64_t *target, uint64_t value, int pe);


should add int32/64, uint32/64 to C11 macro?

xinzhao3 · 2018-11-30T20:44:16Z

oshmem/include/shmem.h.in

+OSHMEM_DECLSPEC int32_t shmem_int32_atomic_fetch_xor(int32_t *target, int32_t value, int pe);
+OSHMEM_DECLSPEC int64_t shmem_int64_atomic_fetch_xor(int64_t *target, int64_t value, int pe);
+OSHMEM_DECLSPEC uint32_t shmem_uint32_atomic_fetch_xor(uint32_t *target, uint32_t value, int pe);
+OSHMEM_DECLSPEC uint64_t shmem_uint64_atomic_fetch_xor(uint64_t *target, uint64_t value, int pe);


should add int32/64, uint32/64 to C11 macro?

xinzhao3 · 2018-11-30T20:44:22Z

oshmem/include/shmem.h.in

+OSHMEM_DECLSPEC int32_t shmem_ctx_int32_atomic_fetch_or(shmem_ctx_t ctx, int32_t *target, int32_t value, int pe);
+OSHMEM_DECLSPEC int64_t shmem_ctx_int64_atomic_fetch_or(shmem_ctx_t ctx, int64_t *target, int64_t value, int pe);
+OSHMEM_DECLSPEC uint32_t shmem_ctx_uint32_atomic_fetch_or(shmem_ctx_t ctx, uint32_t *target, uint32_t value, int pe);
+OSHMEM_DECLSPEC uint64_t shmem_ctx_uint64_atomic_fetch_or(shmem_ctx_t ctx, uint64_t *target, uint64_t value, int pe);


should add int32/64, uint32/64 to C11 macro?

xinzhao3 · 2018-11-30T20:44:28Z

oshmem/include/shmem.h.in

+OSHMEM_DECLSPEC int32_t shmem_ctx_int32_atomic_fetch_and(shmem_ctx_t ctx, int32_t *target, int32_t value, int pe);
+OSHMEM_DECLSPEC int64_t shmem_ctx_int64_atomic_fetch_and(shmem_ctx_t ctx, int64_t *target, int64_t value, int pe);
+OSHMEM_DECLSPEC uint32_t shmem_ctx_uint32_atomic_fetch_and(shmem_ctx_t ctx, uint32_t *target, uint32_t value, int pe);
+OSHMEM_DECLSPEC uint64_t shmem_ctx_uint64_atomic_fetch_and(shmem_ctx_t ctx, uint64_t *target, uint64_t value, int pe);


should add int32/64, uint32/64 to C11 macro?

xinzhao3 · 2018-11-30T20:50:47Z

oshmem/shmem/c/shmem_g.c

@@ -63,6 +63,7 @@
 #pragma weak shmem_ctx_int_g = pshmem_ctx_int_g
 #pragma weak shmem_ctx_long_g = pshmem_ctx_long_g
 #pragma weak shmem_ctx_longlong_g = pshmem_ctx_longlong_g
+#pragma weak shmem_ctx_schar_g = pshmem_ctx_schar_g


I think we need to add int8, int16, int32, int64, uint8, uint16, uint32, uint64, size, ptrdiff here, also same with shmem_p

right, will add in next PR (will add into master first)

hoopoepg · 2018-12-06T14:17:38Z

@xinzhao3 anything else to fix?
we will add shmem_g/p API in next PR (for now we are forcing this PR to allow tests pass)

hppritcha · 2018-12-09T17:21:09Z

@xinzhao3 do you and @hoopoepg have agreement here? Is this PR ready to merge?

hoopoepg · 2018-12-10T05:11:27Z

@hppritcha I think yes, API requested by @xinzhao3 is added in #6168, no more changes are required

hppritcha · 2018-12-10T20:14:35Z

@xinzhao3 could you switch you review to ✅ ?

xinzhao3 · 2018-12-10T20:18:56Z

@hppritcha @hoopoepg I am reviewing this again now, will response soon today.

OSHMEM/AMO: added int/uint/32/64 atomics calls

63cbe36

- added int/uint/32/64 atomics calls - added SHMEM_SYNC_SIZE macro Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com> (cherry picked from commit 4c071da)

hoopoepg changed the title ~~OSHMEM/AMO: added int/uint/32/64 atomics calls~~ OSHMEM/AMO: added int/uint/32/64 atomics calls - v4.0 Nov 26, 2018

hoopoepg added the Target: v4.0.x label Nov 26, 2018

hoopoepg added this to the v4.0.1 milestone Nov 26, 2018

jsquyres mentioned this pull request Nov 27, 2018

v4.0.x: Re-add removed deprecate-only MPI-2.0 symbols #6120

Merged

gpaulsen requested a review from xinzhao3 November 30, 2018 19:59

yosefe approved these changes Dec 2, 2018

View reviewed changes

xinzhao3 suggested changes Dec 4, 2018

View reviewed changes

xinzhao3 approved these changes Dec 11, 2018

View reviewed changes

hppritcha added the RM approved label Dec 11, 2018

hppritcha merged commit 552834b into open-mpi:v4.0.x Dec 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OSHMEM/AMO: added int/uint/32/64 atomics calls - v4.0 #6110

OSHMEM/AMO: added int/uint/32/64 atomics calls - v4.0 #6110

hoopoepg commented Nov 26, 2018

gpaulsen commented Nov 26, 2018

xinzhao3 commented Nov 30, 2018

gpaulsen commented Nov 30, 2018

xinzhao3 commented Nov 30, 2018

xinzhao3 Nov 30, 2018

hoopoepg Dec 4, 2018

xinzhao3 Nov 30, 2018

xinzhao3 Nov 30, 2018

xinzhao3 Nov 30, 2018

xinzhao3 Nov 30, 2018

xinzhao3 Nov 30, 2018

xinzhao3 Nov 30, 2018

xinzhao3 Nov 30, 2018

xinzhao3 Nov 30, 2018

xinzhao3 Nov 30, 2018

hoopoepg Dec 4, 2018

hoopoepg commented Dec 6, 2018

hppritcha commented Dec 9, 2018

hoopoepg commented Dec 10, 2018 •

edited

Loading

hppritcha commented Dec 10, 2018

xinzhao3 commented Dec 10, 2018

OSHMEM/AMO: added int/uint/32/64 atomics calls - v4.0 #6110

OSHMEM/AMO: added int/uint/32/64 atomics calls - v4.0 #6110

Conversation

hoopoepg commented Nov 26, 2018

gpaulsen commented Nov 26, 2018

xinzhao3 commented Nov 30, 2018

gpaulsen commented Nov 30, 2018

xinzhao3 commented Nov 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoopoepg commented Dec 6, 2018

hppritcha commented Dec 9, 2018

hoopoepg commented Dec 10, 2018 • edited Loading

hppritcha commented Dec 10, 2018

xinzhao3 commented Dec 10, 2018

hoopoepg commented Dec 10, 2018 •

edited

Loading