Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fortran/use-mpi-f08: generates PMPI bindings from the MPI bindings #6903

Merged
merged 4 commits into from
Oct 31, 2020
Merged

fortran/use-mpi-f08: generates PMPI bindings from the MPI bindings #6903

merged 4 commits into from
Oct 31, 2020

Conversation

ggouaillardet
Copy link
Contributor

  • via the OMPI_BUILD_MPI_PROFILING macro, avoid the need to have two distinct
    source files for MPI_* and PMPI_* bindings.
  • move the PMPI bindings into ompi/mpi/fortran/use-mpi-f08/profile.
  • remove an useless dependency to mpi-f08.lo

Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp

@ggouaillardet ggouaillardet force-pushed the topic/use-mpi-f08-profile branch from 94c5c28 to aeb9336 Compare August 16, 2019 08:21
@ggouaillardet ggouaillardet requested a review from jsquyres August 16, 2019 08:22
@ggouaillardet
Copy link
Contributor Author

@jsquyres could you please review this ?

this will make the code way more maintainable by avoiding to (virtually) duplicate bindings for both MPI and PMPI

@ggouaillardet ggouaillardet force-pushed the topic/use-mpi-f08-profile branch 2 times, most recently from 6bddd92 to ab2ecd0 Compare August 19, 2019 05:40
@ggouaillardet
Copy link
Contributor Author

@jsquyres I also changed use-mpi-ignore-tkr and use-mpi-tkr to make the code less error prone and more maintainable.

@ggouaillardet ggouaillardet force-pushed the topic/use-mpi-f08-profile branch from ab2ecd0 to 1ad0710 Compare August 25, 2019 10:07
@ggouaillardet
Copy link
Contributor Author

@jsquyres could you please review my latest revision ?

@ibm-ompi
Copy link

ibm-ompi commented Feb 6, 2020

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/e5b81044c203e5b2b300b2bcd2dba821

@lanl-ompi
Copy link
Contributor

Can one of the admins verify this patch?

@jsquyres
Copy link
Member

@ggouaillardet I totally love this PR, and somehow it fell off of my radar. 😦

Any chance you could rebase this to master/HEAD?

@ggouaillardet ggouaillardet force-pushed the topic/use-mpi-f08-profile branch from 1ad0710 to bab6181 Compare October 30, 2020 01:27
@ibm-ompi
Copy link

The IBM CI (PGI) build failed! Please review the log, linked below.

Gist: https://gist.github.com/75df50ef204a73d328bd6b1ddeeeba11

@ggouaillardet ggouaillardet force-pushed the topic/use-mpi-f08-profile branch from bab6181 to f841c7f Compare October 30, 2020 02:06
@ibm-ompi
Copy link

The IBM CI (PGI) build failed! Please review the log, linked below.

Gist: https://gist.github.com/a8c6211b616df33deadde3304b4f659b

@ibm-ompi
Copy link

The IBM CI (PGI) build failed! Please review the log, linked below.

Gist: https://gist.github.com/7d93d5743ce9d031310cb073d364ec93

@ggouaillardet ggouaillardet force-pushed the topic/use-mpi-f08-profile branch from ec12477 to 9fe1350 Compare October 30, 2020 04:18
@ggouaillardet
fortran/use-mpi-f08: generates PMPI bindings from the MPI bindings
5219241 
 - via the OMPI_BUILD_MPI_PROFILING macro, avoid the need to have two distinct
   source files for MPI_* and PMPI_* bindings.
 - move the PMPI bindings into ompi/mpi/fortran/use-mpi-f08/profile.
 - remove an useless dependency to mpi-f08.lo
 - share most of mod/[p]mpi-f08-interfaces.F90 code in a single mod/mpi-f08-interfaces.h

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
fortran/use-mpi-f08: simplify mod/mpi-f08-interfaces.h
c2e3df6 
have this file generated at configure time and use the
@OMPI_FORTRAN_IGNORE_TKR_PREDECL@ and @OMPI_FORTRAN_IGNORE_TKR_TYPE@
variable for buffer definitions

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
fortran/use-mpi-ignore-tkr: revamp PMPI_* declarations
e981e46 
only declare MPI_* bindings and use macros to deduce the PMPI_* bindings

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
fortran/use-mpi-tkr: revamp PMPI_* declarations
8c2b916 
only declare MPI_* bindings and use macros to deduce the PMPI_* bindings

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet ggouaillardet force-pushed the topic/use-mpi-f08-profile branch from 9fe1350 to 8c2b916 Compare October 30, 2020 05:01
@ggouaillardet
Copy link
Contributor Author

@jsquyres I rebased this PR

jsquyres
jsquyres approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a bunch of testing and it all checks out.

@jsquyres jsquyres merged commit c7b968e into open-mpi:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquyres jsquyres jsquyres approved these changes

Assignees
No one assigned
Labels
code cleanup fortran bindings Target: main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ggouaillardet @ibm-ompi @lanl-ompi @jsquyres @bwbarrett