btl/vader: when using single-copy emulation fragment large rdma #6961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes how the single-copy emulation in the vader btl operates. Before this change the BTL set its put and get limits based on the max send size. After this change the limits are unset and the put or get operation is fragmented internally. References open-mpi#6568 Signed-off-by: Nathan Hjelm <hjelmn@google.com>
|
@hjelmn is this an alternate workaround to the OB1 PUT issue? |
|
This is a work around to issues with fragmented gets in ob1. |
|
Probably helps with puts too. |
bosilca
approved these changes
Sep 7, 2019
|
For the sake of completeness, this provides a nice partial solution to the PUT issue, but ensuring that the vader BTL accepts to handle very large fragments, removing the PML need to fragment messages. However, it does not fix the UT protocol, which remains broken for all multi-fragments messages. |
|
@bosilca can you be more specific? What protocols and components are affected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how the single-copy emulation in the vader btl
operates. Before this change the BTL set its put and get limits
based on the max send size. After this change the limits are unset
and the put or get operation is fragmented internally.
References #6568
Signed-off-by: Nathan Hjelm hjelmn@google.com