Neighbor alltoall fix #7232
Merged
Neighbor alltoall fix #7232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the coll/basic component to correctly order sends and receives for cartesian communicators with cyclic boundaries. This addresses an issue identified by mpi-forum/mpi-issues#153. This issue occurs when the size in any dimension is 1. This gives the same neighbor in the positive and negative directions. The old code was sending and receiving in the same order so the -1 buffer contained the +1 result and vise-versa. The problem is addressed by using unique tags for each send. This should cover both the case where overtaking is allowed and is not allowed. The former case will be possible is a MPI_Cart_create_with_info() call is added to the standard. Signed-off-by: Nathan Hjelm <hjelmn@google.com>
This work is rooted in the [MPI Forum issue 153](mpi-forum/mpi-issues#153). Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
|
bot:ompi:retest |
|
@hppritcha @bwbarrett Any idea how this PR is failing CI in configure when @bosilca didn't touch any configury in this PR? |
|
bot:ompi:retest |
hjelmn
approved these changes
Dec 17, 2019
|
@bosilca @hjelmn Is there anything else to do on this PR, or is mpi-forum/mpi-issues#153 now fully fixed? |
|
We are now fully MPI compliant, at least from the neighbor collective point of view. As for what is left to be done: we need to push this into the stable branches. |
This was referenced Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for @hjelmn #7063.