v3.0.x: Fix mmap infinite recurse in memory patcher #7242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue #6853 by removing MacOS/Darwin-specific logic from intercept_mmap. Signed-off-by: Harumi Kuno <harumi.kuno@hpe.com>
|
Confirmed that with this patch, OMPI compiles correctly in RHEL 8.0 and RHEL 7.6 and that the resulting installation can compile and execute the OSU micro benchmarks over the PSM2 MTL. I have not exhaustively tested other transports, but that should not be relevant to this patch. |
jsquyres
changed the title
jsquyres
approved these changes
Dec 17, 2019
|
Thank you, Michael, for testing and validating this! I had not merged this patch into 3 because I didn't want to do that unless I could build and demonstrate that the 3.0.x branch would hit the bug without the fix, and I had trouble demonstrating that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Harumi Kuno's patch from July 30th to 3.0.x. This corrects issue #7212.
This commit fixes issue #6853 by removing
MacOS/Darwin-specific logic from intercept_mmap.
Signed-off-by: Harumi Kuno harumi.kuno@hpe.com