Skip to content

Oshmem atomic set fix #7249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Oshmem atomic set fix #7249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb5ff55
oshmem/ucx: fixed a build issue
Dec 19, 2019
2d8f9b1
oshmem/extended: Fix shmem_atomic_set for float and double.
Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions oshmem/mca/sshmem/ucx/sshmem_ucx_module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ segment_create(map_segment_t *ds_buf,
unsigned flags;

#if HAVE_UCX_DEVICE_MEM
int ret = OSHMEM_ERROR;
if (hint & SHMEM_HINT_DEVICE_NIC_MEM) {
if (size > UINT_MAX) {
return OSHMEM_ERR_BAD_PARAM;
Expand Down
5 changes: 3 additions & 2 deletions oshmem/shmem/c/shmem_set.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,18 @@
int rc = OSHMEM_SUCCESS; \
size_t size = 0; \
type out_value; \
\
uint64_t value_tmp; \
RUNTIME_CHECK_INIT(); \
RUNTIME_CHECK_PE(pe); \
RUNTIME_CHECK_ADDR(target); \
\
size = sizeof(out_value); \
memcpy(&value_tmp, &value, size); \
rc = MCA_ATOMIC_CALL(swap( \
ctx, \
(void*)target, \
(void*)&out_value, \
value, \
value_tmp, \
size, \
pe)); \
RUNTIME_CHECK_RC(rc); \
Expand Down