Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPML/UCX: Fix compilation warnings with GCC #7353

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

dmitrygx
Copy link
Member

@dmitrygx dmitrygx commented Feb 2, 2020

This patch fixes the following compilation warning produced by GCC 4.8.5:

make[2]: Entering directory `/root/ompi/oshmem/mca/spml/ucx'
  CC       spml_ucx_component.lo
  CC       spml_ucx.lo
spml_ucx.c: In function 'mca_spml_ucx_del_procs':
spml_ucx.c:134:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         for (w = 0; w < ucp_workers; w++) {
                       ^
spml_ucx.c: In function 'mca_spml_ucx_add_procs':
spml_ucx.c:328:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (w = 0; w < ucp_workers; w++) {
                   ^
spml_ucx.c:335:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         for (w = 0; w < ucp_workers; w++, i++) {
                       ^
spml_ucx.c:389:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         for (w = 0; w < ucp_workers; w++) {
                       ^
spml_ucx.c:284:18: warning: unused variable 'k' [-Wunused-variable]
     size_t i, j, k, w, n;
                  ^
spml_ucx.c: In function 'mca_spml_ucx_ctx_create':
spml_ucx.c:754:31: warning: unused variable 'active_array' [-Wunused-variable]
     mca_spml_ucx_ctx_array_t *active_array = &mca_spml_ucx.active_array;
                               ^
  CCLD     mca_spml_ucx.la

@dmitrygx
Copy link
Member Author

dmitrygx commented Feb 2, 2020

@brminich @hoopoepg @janjust could you review pls?

@artemry-nv
Copy link

@dmitrygx
Wrong commit author - Mellanox CI failed.

@dmitrygx
Copy link
Member Author

dmitrygx commented Feb 3, 2020

@dmitrygx
Wrong commit author - Mellanox CI failed.

@artemry-mlnx thank you, fixed!

oshmem/mca/spml/ucx/spml_ucx.c Show resolved Hide resolved
Signed-off-by: Dmitry Gladkov <dmitrygla@mellanox.com>
@dmitrygx
Copy link
Member Author

dmitrygx commented Feb 4, 2020

@brminich could you check the fix for your comment pls?

@dmitrygx
Copy link
Member Author

dmitrygx commented Feb 4, 2020

@yosefe could you review, please?

@yosefe yosefe merged commit 1047e28 into open-mpi:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants