Correctly set baseptr in contiguous shared memory window with local size zero (v3.0.x) #7440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize zero Signed-off-by: Joseph Schuchart <schuchart@hlrs.de> (cherry picked from commit 06bbcf4)
|
I think @hjelmn would be better to give a review than me. 😄 |
|
@hjelmn Ping. |
hjelmn
approved these changes
Feb 27, 2020
|
Decided to pull this into 3.1.x because (1) it's simple and easy to understand and (2) we need to fire up a new MTT run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MPI standard mandates that for contiguous shared memory windows the returned
baseptrcan be used to directly calculate the remote addresses on other processes so we cannot returnNULLifsize == 0.Cherry-pick of #7204 to the v3.0.x branch.
Signed-off-by: Joseph Schuchart schuchart@hlrs.de
(cherry picked from commit 06bbcf4)