Fix Bcast scatter_allgather #7523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Kurnosov <mkurnosov@gmail.com>
Member
|
@jladd-mlnx could you assign someone from your org to review? |
hppritcha
approved these changes
Mar 17, 2020
Member
|
@jladd-mlnx please review and merge if it looks good to you |
Member
|
@jladd-mlnx repinging |
jladd-mlnx
reviewed
Mar 27, 2020
Member
jladd-mlnx
left a comment
jladd-mlnx
left a comment
There was a problem hiding this comment.
This fix is fine. However, might I suggest making the send from the proxy rank be a non-blocking isend. There's no reason to block the next step of recursive doubling. Non-power-of-two is the general case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #7410 with incorrect size of receiving message on the recursive doubling phase (in the case of non-power-of-two number of processes).
Signed-off-by: Mikhail Kurnosov mkurnosov@gmail.com