Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix in cmd line parser help #7897

Merged
merged 2 commits into from
Aug 8, 2020

Conversation

cniethammer
Copy link
Contributor

Fix wrong enum type in default command line option category assignment
Update out of sync in code documentation for opal_cmd_line_create()

Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
@cniethammer
Copy link
Contributor Author

Note: This fix affects the display of the help as
OPAL_CMD_LINE_OTYPE_NULL != OPAL_CMD_LINE_TYPE_NULL

@cniethammer
Copy link
Contributor Author

@rhc54: This code seems also present in openpmix and prrte and will need updating there as well.

@rhc54
Copy link
Contributor

rhc54 commented Jun 30, 2020

This won't have any impact in master - OPAL isn't used to parse the PRRTE cmd line.

@jsquyres
Copy link
Member

jsquyres commented Aug 8, 2020

bot:aws:retest

@jsquyres jsquyres merged commit f5cb1a4 into open-mpi:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants