Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second take on fixing the Intel _Atomic atomic operation warning #7915

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

bosilca
Copy link
Member

@bosilca bosilca commented Jul 8, 2020

We completely disable C11 atomic op support for _Atomic for
all Intel compiler prior to 20200310 (which is currently the
latest released), by switching to our pre-C11 atomic operations.

Signed-off-by: George Bosilca bosilca@icl.utk.edu

Copy link
Member

@hjelmn hjelmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some submodule changes made it into this PR. Please fix.

We completely disable C11 atomic op support for _Atomic for
all Intel compiler prior to 20200310 (which is currently the
latest released), by switching to our pre-C11 atomic
operations.

Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
@bosilca bosilca force-pushed the fix/intel_2330_warning_take2 branch from faa66da to ddfb4de Compare July 8, 2020 13:59
@jsquyres
Copy link
Member

jsquyres commented Aug 8, 2020

@hjelmn @bosilca Is this good to go?

Copy link
Member

@hjelmn hjelmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjelmn hjelmn merged commit a44914c into open-mpi:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants