Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.1: Fix memory leak in configure, which prevents leak sanitizer usage #7959

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

cniethammer
Copy link
Contributor

@cniethammer cniethammer commented Jul 22, 2020

Backport of #7953

If building Open MPI with sanitizers, e.g
$ configure CC=clang CFLAGS=-fsanitize=address ....
configure test programs are also build with the sanitizers and will
report errors resulting in configure to fail.

Signed-off-by: Christoph Niethammer <niethammer@hlrs.de>
@jsquyres jsquyres added this to the v4.1.0 milestone Jul 22, 2020
@jsquyres jsquyres changed the title Fix memory leak in configure, which prevents leak sanitizer usage v4.1: Fix memory leak in configure, which prevents leak sanitizer usage Jul 22, 2020
@jsquyres
Copy link
Member

@bwbarrett We periodically get SSL cert failures on the AWS CI. Here's an example:

FailedConsole Output
Started by upstream project "open-mpi.build.autogen_options" build number 6643
originally caused by:
 Started by upstream project "open-mpi.pull_request" build number 6811
 originally caused by:
  GitHub pull request #7959 of commit e0bd64f843b47751d069222c06cb622a5b37a801, no merge conflicts.
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on EC2 (Open MPI AWS Production) - Ubuntu 16.04 (i-0f131911bea8ee1a9) (32bit_builds clang38 clang36 clang37 ubuntu_16.04 gcc48 pandoc gcc47 ec2 gcc49 linux gcc5) in workspace /home/ubuntu/workspace/open-mpi.build.autogen_options/AUTOGEN_OPTIONS/--no-oshmem
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
No credentials specified
Cloning the remote Git repository
Cloning repository https://github.com/open-mpi/ompi/
 > git init /home/ubuntu/workspace/open-mpi.build.autogen_options/AUTOGEN_OPTIONS/--no-oshmem/src # timeout=10
Fetching upstream changes from https://github.com/open-mpi/ompi/
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/open-mpi/ompi/ +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url https://github.com/open-mpi/ompi/ # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url https://github.com/open-mpi/ompi/ # timeout=10
Fetching upstream changes from https://github.com/open-mpi/ompi/
 > git fetch --tags --progress https://github.com/open-mpi/ompi/ +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/remotes/origin/pr/* # timeout=10
JENKINS-19022: warning: possible memory leak due to Git plugin usage; see: https://wiki.jenkins.io/display/JENKINS/Remove+Git+Plugin+BuildsByBranch+BuildData
Checking out Revision b77bc82f1dd3013873ab5ee5de9f98cd5ad6fa94 (refs/remotes/origin/pr/7959/merge)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f b77bc82f1dd3013873ab5ee5de9f98cd5ad6fa94 # timeout=10
Commit message: "Merge e0bd64f843b47751d069222c06cb622a5b37a801 into 18418bfdf68264410fe6966101bf5483d61beaaf"
First time build. Skipping changelog.
[--no-oshmem] $ /bin/sh -xe /tmp/jenkins7831509519832652370.sh
+ curl https://raw.githubusercontent.com/open-mpi/ompi-scripts/master/jenkins/open-mpi-build-script.sh -o open-mpi-build-script.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (77) Problem with the SSL CA cert (path? access rights?)
Build step 'Execute shell' marked build as failure
Finished: FAILURE

Any idea what this is about?

(you previously told me not to "retest" when there's CI infrastructure issues like this so that you can still go in and see the failed job details, so I won't issue a "retest" for this yet...)

@jsquyres
Copy link
Member

jsquyres commented Jul 27, 2020

We don't have time to look at the CI issue right now, so just going to retest.

@bwbarrett
Copy link
Member

bot:ompi:retest

@bwbarrett bwbarrett merged commit e08e15c into open-mpi:v4.1.x Jul 28, 2020
@cniethammer cniethammer deleted the configure-leak-fix-v4.1.x branch July 28, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants