Adding ofi include to CPPFLAGS so that configure can check fabric.h #8093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ric.h configure was previously failing to check for the fi_info.nic struct because fabric.h relied on other header files in the ofi/include dir. This adds that include to CPPFLAGS before running that check so that configure can check for the struct. Signed-off-by: Nikola Dancejic <dancejic@amazon.com>
jsquyres
approved these changes
Oct 15, 2020
|
@dancejic Does this commit also need to be ported to the v4.0.x and v4.1.x branches? |
|
yes, I'll open PRs for those as well. |
|
@dancejic Make sure to register for Hacktoberfest 😉 |
|
Looks like the multi-NIC code isn't in 4.0.x, but I did open a PR for 4.1.x: #8094. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure was previously failing to check for the fi_info.nic struct because
fabric.h relied on other header files in the ofi/include dir. This adds that
include to CPPFLAGS before running that check so that configure can check for
the struct.
Signed-off-by: Nikola Dancejic dancejic@amazon.com