osc/rdma: Fix some bugs running with btl/tcp. #8719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awlauria
force-pushed
the
fix_osc_rdma_tcp_bugs
branch
2 times, most recently
from
6443523 to
dad72d3
Compare
bosilca
previously requested changes
Mar 26, 2021
| @@ -529,6 +529,7 @@ static int allocate_state_single (ompi_osc_rdma_module_t *module, void **base, s | |||
| my_peer->state_handle = module->state_handle; | |||
| my_peer->state_btl_index = my_peer->data_btl_index; | |||
| my_peer->state_endpoint = my_peer->data_endpoint; | |||
| assert(my_peer -> state_endpoint != NULL); | |||
There was a problem hiding this comment.
Right - removed these asserts(). Thanks.
| pending_op->op_frag->handle, (void *) pending_op, NULL, OPAL_SUCCESS); | ||
| } else { | ||
| /* need to release here because ompi_osc_rdma_atomic_complete was not called */ | ||
| OBJ_RELEASE(pending_op); |
awlauria
force-pushed
the
fix_osc_rdma_tcp_bugs
branch
2 times, most recently
from
23fd874 to
a0d4106
Compare
- Make sure peer->state_endpoint is set correctly. - Fix double free of pending_op in ompi_osc_rdma_btl_fop() and ompi_osc_rdma_btl_op(). Cleanup/leaks: - Don't parse ompi_osc_rdma_btl_alternate_names twice. - free temp in allocate_state_shared(). Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
awlauria
force-pushed
the
fix_osc_rdma_tcp_bugs
branch
from
a0d4106 to
928ac83
Compare
|
Found another double-free. Should be good to go. |
awlauria
dismissed
bosilca’s stale review
@boslica comments have been addressed. Ready for re-review
|
I cherry-picked this commit into #8756. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup/leaks: