opal/Makefile.am Remove duplicate symbols for common_cuda #8788
Conversation
|
Issue from #8736 |
|
You should really update the commit message to include why this change is the right change. |
These symbols were causing compilation errors with cuda and the new default statically linked components. Explicitly including common_cuda is unnecessary because the MCA system adds it, which, when built as a static library, caused duplicates. Issue open-mpi#8736 Signed-off-by: William Zhang <wilzhang@amazon.com>
|
@bwbarrett @wckzhang for cuda changes like from this PR, does CI check cuda builds/tests? |
Unfortunately I don't believe we have cuda builds/tests (though I might be wrong). For what it's worth, it compiled properly for myself and #8656 (comment) Daniel |
|
@Akshay-Venkatesh It would be fantastic if NVIDIA could do CI builds with CUDA. Hint, hint. 😃 |
|
If I'm reading the logs correctly, the PRBC CI failed due to instance connectivity, I'll try restarting it. |
|
bot:ompi:retest |
Hey @jsquyres Definitely needed. Working on that in the background actually. I wanted to check with Brian and William because some changes were made to common/cuda paths and was mostly hoping that cuda builds were tested after changes. |
|
Turns out I don't have write permissions for this repo... @jsquyres how can I get it? |
|
@wckzhang Done.
|
|
With great ability comes great accountability :) |
These symbols were causing compilation errors with cuda and the new
default statically linked components.
Signed-off-by: William Zhang wilzhang@amazon.com