v4.0.x: Thread fixes #9311
Merged
v4.0.x: Thread fixes #9311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on after wait completes. We found an issue where with using multiple threads, it is possible for the data to not be in the buffer before MPI_Wait() returns. Testing the buffer later after MPI_Wait() returned would show the data arrives eventually without the rmb(). We have seen this issue on Power9 intermittently using PAMI, but in theory could happen with any transport. Signed-off-by: Austen Lauria <awlauria@us.ibm.com> (cherry picked from commit 12192f1)
Signed-off-by: Austen Lauria <awlauria@us.ibm.com> (cherry picked from commit babfd93)
|
bot:aws:retest |
bosilca
approved these changes
Aug 26, 2021
hppritcha
approved these changes
Aug 27, 2021
|
This PR contains a commit effecting a behavior change to MPI_INIT_THREAD that really should not be under the name "Thread fixes". See #9331. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue where with using multiple threads, it is possible for the data
to not be in the buffer before MPI_Wait() returns. Testing the buffer later after
MPI_Wait() returned would show the data arrives eventually without the rmb().
We have seen this issue on Power9 intermittently using PAMI, but in theory could
happen with any transport.
Signed-off-by: Austen Lauria awlauria@us.ibm.com
(cherry picked from commit 12192f1)
Signed-off-by: Austen Lauria awlauria@us.ibm.com
(cherry picked from commit babfd93)