master: portals4: fix compiler warnings in all the Portals4 components #9391
+125
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move recv init inside the interface init loop
- fix uninitialized variable compiler warnings
- fix unused variable compiler warnings
- fix undefined variable failures in debug builds
mtl-portals4:
- move verbose output to the end of open() to avoid complicated message generation
- use opal_atomic_int32_t instead of bare int32_t
- remove unneeded cast to bare int32_t
- cast to opal_atomic_int64_t instead of bare int64_t
- there is no function to add-fetch uint32_t, so change event_count type to opal_atomic_int32_t
coll-portals4:
- move declaration of loop index variables into the loop
- fix hidden loop index compiler warnings
- use REQUEST_COMPLETE to mark ompi_request_t complete
- remove incorrect req_complete initialization
osc-portals4:
- replace nonstatndard __FUNCTION__ references with __FILE__
- use REQUEST_COMPLETE to mark ompi_request_t complete
- remove incorrect req_complete initialization
- add atomic compatible bytes_committed member to ompi_osc_portals4_request_t
- the request status _ucount member shouldn't be incremented with opal_atomic_add_fetch_32() because it isn't declared with _Atomic.
- instead increment bytes_committed and assigned the result to _ucount.
Signed-off-by: Todd Kordenbrock <thkgcode@gmail.com>
mdosanjh
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
btl-portals4:
mtl-portals4:
opal_atomic_int32_tinstead of bareint32_tint32_topal_atomic_int64_tinstead of bareint64_tuint32_t, so change event_count type toopal_atomic_int32_tcoll-portals4:
REQUEST_COMPLETEto markompi_request_tcompleteosc-portals4:
__FUNCTION__references with__FILE__REQUEST_COMPLETEto markompi_request_tcompleteompi_osc_portals4_request_t_ucountmember shouldn't be incremented withopal_atomic_add_fetch_32()because it isn't declared with _Atomicbytes_committedand assigned the result to_ucountSigned-off-by: Todd Kordenbrock thkgcode@gmail.com
Closes #9390