Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check preempted in navigating to staging pose #57

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Check preempted in navigating to staging pose #57

merged 8 commits into from
Aug 7, 2024

Conversation

redvinaa
Copy link
Contributor

Implementing #54

@redvinaa
Check preempted in navigating to staging pose
56ccebf 
Signed-off-by: redvinaa <redvinaa@gmail.com>
SteveMacenski
SteveMacenski requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, a few nit picks and then we can push this into Nav2 + I can backport to Humble / Jazzy

opennav_docking/include/opennav_docking/navigator.hpp Outdated Show resolved Hide resolved
opennav_docking/src/navigator.cpp Outdated Show resolved Hide resolved
opennav_docking/src/navigator.cpp Outdated Show resolved Hide resolved
opennav_docking/src/navigator.cpp Outdated Show resolved Hide resolved
opennav_docking/src/navigator.cpp Outdated Show resolved Hide resolved
redvinaa added 2 commits July 31, 2024 16:39
@redvinaa
Requested changes
37b649f 
Signed-off-by: redvinaa <redvinaa@gmail.com>
@redvinaa
Requested changes vol 2
053fac5
SteveMacenski
SteveMacenski requested changes Jul 31, 2024
View reviewed changes
opennav_docking/src/navigator.cpp Outdated Show resolved Hide resolved
opennav_docking/src/navigator.cpp Outdated Show resolved Hide resolved
opennav_docking/src/navigator.cpp Outdated Show resolved Hide resolved
opennav_docking/src/navigator.cpp Show resolved Hide resolved
redvinaa added 4 commits August 1, 2024 13:35
@redvinaa
Requested changes vol 3
1df3d83 
Signed-off-by: redvinaa <redvinaa@gmail.com>
@redvinaa
Fix tests
365ea81 
Signed-off-by: redvinaa <redvinaa@gmail.com>
@redvinaa
Fix remaining time calculation
e523c31 
Signed-off-by: redvinaa <redvinaa@gmail.com>
@redvinaa
Document missing args
e705cc3 
Signed-off-by: redvinaa <redvinaa@gmail.com>
SteveMacenski
SteveMacenski approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@SteveMacenski SteveMacenski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please open the Nav2 counterpart and I'll merge the pair. Thanks for the back and forth!

@redvinaa redvinaa mentioned this pull request Aug 6, 2024
Merged
@redvinaa
Copy link
Contributor Author

redvinaa commented Aug 6, 2024

Done

@redvinaa
Lint
6861a05 
Signed-off-by: redvinaa <redvinaa@gmail.com>
@SteveMacenski SteveMacenski merged commit b8001de into open-navigation:main Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redvinaa @SteveMacenski