Skip to content

Commit

Permalink
remove legacy grpc receiver endpoint for GA release (open-telemetry#3256
Browse files Browse the repository at this point in the history
)

* remove legacy grpc receiver endpoint for GA release

* Update factory.go

Co-authored-by: Bogdan Drutu <lazy@splunk.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
  • Loading branch information
3 people committed May 26, 2021
1 parent ab616c8 commit 1292bf4
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions examples/k8s/otel-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ data:
http:
exporters:
otlp:
endpoint: "otel-collector.default:55680" # TODO: Update me
endpoint: "otel-collector.default:4317"
insecure: true
sending_queue:
num_consumers: 4
Expand Down Expand Up @@ -78,7 +78,7 @@ spec:
memory: 100Mi
ports:
- containerPort: 55679 # ZPages endpoint.
- containerPort: 55680 # Default OpenTelemetry receiver port.
- containerPort: 4317 # Default OpenTelemetry receiver port.
- containerPort: 8888 # Metrics.
volumeMounts:
- name: otel-agent-config-vol
Expand Down Expand Up @@ -159,9 +159,9 @@ metadata:
spec:
ports:
- name: otlp # Default endpoint for OpenTelemetry receiver.
port: 55680
port: 4317
protocol: TCP
targetPort: 55680
targetPort: 4317
- name: jaeger-grpc # Default endpoint for Jaeger gRPC receiver
port: 14250
- name: jaeger-thrift-http # Default endpoint for Jaeger HTTP receiver.
Expand Down Expand Up @@ -211,7 +211,7 @@ spec:
memory: 400Mi
ports:
- containerPort: 55679 # Default endpoint for ZPages.
- containerPort: 55680 # Default endpoint for OpenTelemetry receiver.
- containerPort: 4317 # Default endpoint for OpenTelemetry receiver.
- containerPort: 14250 # Default endpoint for Jaeger HTTP receiver.
- containerPort: 14268 # Default endpoint for Jaeger HTTP receiver.
- containerPort: 9411 # Default endpoint for Zipkin receiver.
Expand Down
4 changes: 2 additions & 2 deletions exporter/otlpexporter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ Example:
```yaml
exporters:
otlp:
endpoint: otelcol2:55680
endpoint: otelcol2:4317
cert_file: file.cert
key_file: file.key
otlp/2:
endpoint: otelcol2:55680
endpoint: otelcol2:4317
insecure: true
```
Expand Down
2 changes: 1 addition & 1 deletion testbed/testbed/receivers.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ func (bor *BaseOTLPDataReceiver) GenConfigYAMLStr() string {
return str
}

const DefaultOTLPPort = 55680
const DefaultOTLPPort = 4317

// NewOTLPDataReceiver creates a new OTLP DataReceiver that will listen on the specified port after Start
// is called.
Expand Down

0 comments on commit 1292bf4

Please sign in to comment.