Skip to content

Commit

Permalink
Update dependencies, use 'noCheck: true'
Browse files Browse the repository at this point in the history
  • Loading branch information
mbeckem committed Oct 21, 2024
1 parent db959b5 commit 7668cd9
Show file tree
Hide file tree
Showing 13 changed files with 1,340 additions and 1,862 deletions.
5 changes: 5 additions & 0 deletions .changeset/gentle-moons-rescue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@open-pioneer/build-package": minor
---

Use the new `noCheck` option when generation TypeScript declaration files (.d.ts). This can speed up the generation process, since typechecking is done during the main compilation (linting) stage.
7 changes: 7 additions & 0 deletions .changeset/khaki-pants-search.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@open-pioneer/build-package": patch
"@open-pioneer/build-common": patch
"@open-pioneer/vite-plugin-pioneer": patch
---

Update dependencies.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class Highlights {
/**
* This method displays geometries or BaseFeatures with optional styling in the map
*/
addHighlight(displayTarget: DisplayTarget[], highlightOptions: HighlightOptions | undefined) {
addHighlight(displayTarget: DisplayTarget[], highlightOptions: HighlightOptions | undefined): Highlight {
const geometries = this.#filterGeoobjects(displayTarget);

if (geometries.length === 0) {
Expand Down Expand Up @@ -166,7 +166,7 @@ export class Highlights {
addHighlightAndZoom(
displayTarget: DisplayTarget[],
highlightZoomStyle: HighlightZoomOptions | undefined
) {
): Highlight {
const result = this.addHighlight(displayTarget, highlightZoomStyle);
this.zoomToHighlight(displayTarget, highlightZoomStyle);
return result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export class MapModelImpl extends EventEmitter<MapModelEvents> implements MapMod
this.#highlights.zoomToHighlight(geometries, options);
}

highlightAndZoom(geometries: Geometry[], options?: HighlightZoomOptions) {
highlightAndZoom(geometries: Geometry[], options?: HighlightZoomOptions): Highlight {
return this.#highlights.addHighlightAndZoom(geometries, options ?? {});
}

Expand Down
44 changes: 27 additions & 17 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,24 @@
"ci:publish": "pnpm run clean && pnpm run build && pnpm publish -r --access public && pnpm changeset tag"
},
"devDependencies": {
"@changesets/cli": "^2.27.7",
"@types/node": "^18.19.41",
"@typescript-eslint/eslint-plugin": "^7.17.0",
"@typescript-eslint/parser": "^7.17.0",
"esbuild": "^0.23.0",
"eslint": "^8.57.0",
"@changesets/cli": "^2.27.9",
"@types/node": "^18.19.57",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"esbuild": "^0.24.0",
"eslint": "^8.57.1",
"eslint-config-prettier": "^9.1.0",
"eslint-import-resolver-typescript": "^3.6.1",
"eslint-import-resolver-typescript": "^3.6.3",
"eslint-plugin-header": "^3.1.1",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-import": "^2.31.0",
"eslint-plugin-unused-imports": "^3.2.0",
"husky": "^9.1.1",
"lint-staged": "^15.2.7",
"husky": "^9.1.6",
"lint-staged": "^15.2.10",
"prettier": "^3.3.3",
"rimraf": "^5.0.9",
"typescript": "^5.5.4",
"vite": "^5.4.8",
"vitest": "^2.0.4"
"rimraf": "^5.0.10",
"typescript": "^5.6.3",
"vite": "^5.4.9",
"vitest": "^2.1.3"
},
"engines": {
"node": ">= 18",
Expand All @@ -50,20 +50,30 @@
"semver: https://github.com/advisories/GHSA-c2qf-rxjj-qqgw",
"braces: https://github.com/advisories/GHSA-grv7-fg5c-xmjg",
"fast-loops: https://github.com/advisories/GHSA-3q56-9cc2-46j4",
"micromatch: https://github.com/advisories/GHSA-952p-6rrq-rcjv"
"micromatch: https://github.com/advisories/GHSA-952p-6rrq-rcjv",
"@open-pioneer/runtime: mixed versions, see below",
"",
"peers:",
"trails package overrides can be removed when they no longer use peer deps.",
"these are in conflict because the integration tests use old versions of those packages."
],
"overrides": {
"semver@<7.5.2": ">=7.5.2",
"braces@<3.0.3": ">=3.0.3",
"fast-loops@<1.1.4": ">=1.1.4",
"micromatch@<4.0.8": ">=4.0.8"
"micromatch@<4.0.8": ">=4.0.8",
"@open-pioneer/runtime": ">= 2.2.0"
},
"auditConfig": {
"ignoreCves": []
},
"peerDependencyRules": {
"allowedVersions": {
"@open-pioneer/chakra-integration>framer-motion": ">=4.0.0"
"@open-pioneer/chakra-integration>framer-motion": ">=4.0.0",
"@open-pioneer/base-theme": "*",
"@open-pioneer/chakra-integration@^2.2.0": "*",
"@open-pioneer/runtime-react-support@^1.0.2": "*",
"@open-pioneer/core": "*"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/build-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"dependencies": {
"semver": "^7.6.3",
"zod": "^3.23.8",
"zod-validation-error": "^3.0.0"
"zod-validation-error": "^3.4.0"
},
"engines": {
"node": ">= 18"
Expand Down
16 changes: 8 additions & 8 deletions packages/build-package/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,29 +45,29 @@
"dependencies": {
"@open-pioneer/build-common": "workspace:^",
"@open-pioneer/build-support": "workspace:^",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-node-resolve": "^15.3.0",
"chalk": "^5.3.0",
"debug": "^4.3.5",
"esbuild": "^0.23.0",
"debug": "^4.3.7",
"esbuild": "^0.24.0",
"fast-glob": "^3.3.2",
"find-git-root": "^1.0.4",
"find-workspaces": "^0.3.1",
"fs-extra": "^11.2.0",
"import-meta-resolve": "^4.1.0",
"postcss": "^8.4.39",
"postcss-import": "^16.0.0",
"rollup": "^4.19.0",
"rollup": "^4.24.0",
"rollup-plugin-esbuild": "^6.1.1"
},
"devDependencies": {
"@rollup/pluginutils": "^5.1.0",
"@rollup/pluginutils": "^5.1.2",
"@types/debug": "^4.1.12",
"@types/fs-extra": "^11.0.4",
"@types/postcss-import": "^14.0.3",
"@types/react": "^18.3.3",
"@types/react": "^18.3.11",
"build-tools": "workspace:*",
"sass": "^1.77.8",
"typescript": "^5.5.4"
"sass": "^1.80.3",
"typescript": "^5.6.3"
},
"engines": {
"node": ">= 18"
Expand Down
23 changes: 1 addition & 22 deletions packages/build-package/src/buildDts.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,28 +133,7 @@ describe(
`);

const messages = defaults.logger.messages.map((m) => m.args[0]!);
expect(messages[0]).match(/Cannot find module 'does-not-exist'/);
expect(messages[1]).match(/Cannot assign to 'A' because it is a constant/);
expect(messages[2]).match(/Cannot find name 'f'/);
});

it("throws when strict mode is enabled and typescript emits compiler errors", async function () {
const packageDirectory = resolve(TEST_DATA_DIR, "project-with-typescript-errors");
const outputDirectory = resolve(TEMP_DATA_DIR, "project-with-typescript-errors-strict");
const defaults = testDefaults();

await cleanDir(outputDirectory);
await expect(
buildDts({
...defaults,
packageDirectory,
outputDirectory,
entryPoints: normalize(["index"]),
strict: true
})
).rejects.toThrowErrorMatchingInlineSnapshot(
`[Error: Aborting due to compilation errors (strict validation is enabled).]`
);
expect(messages.length).toBe(0);
});
},
{
Expand Down
6 changes: 5 additions & 1 deletion packages/build-package/src/buildDts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,11 @@ function createTypeScriptConfig(
emitDeclarationOnly: true,
skipLibCheck: true,
noEmitOnError: false,
declarationDir: outputDirectory
declarationDir: outputDirectory,

// Disable type checks. We expect that those are done by the main build
// and not during the compilation of individual packages.
noCheck: true
};

options = {
Expand Down
24 changes: 12 additions & 12 deletions packages/vite-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,32 +37,32 @@
"vite": "^5.0.0"
},
"dependencies": {
"@babel/generator": "^7.24.10",
"@babel/template": "^7.24.7",
"@babel/types": "^7.24.9",
"@babel/generator": "^7.25.7",
"@babel/template": "^7.25.7",
"@babel/types": "^7.25.8",
"@open-pioneer/build-common": "workspace:^",
"debug": "^4.3.5",
"debug": "^4.3.7",
"js-yaml": "^4.1.0",
"vitefu": "^0.2.5",
"vitefu": "^1.0.3",
"zod": "^3.23.8",
"zod-validation-error": "^3.0.0"
"zod-validation-error": "^3.4.0"
},
"devDependencies": {
"@open-pioneer/build-support": "workspace:^",
"@open-pioneer/runtime": "^2.1.6",
"@open-pioneer/runtime": "^2.2.0",
"@open-pioneer/vite-plugin-pioneer": "workspace:^",
"@types/babel__generator": "^7.6.8",
"@types/babel__template": "^7.4.4",
"@types/debug": "^4.1.12",
"@types/js-yaml": "^4.0.9",
"build-tools": "workspace:*",
"esbuild": "^0.23.0",
"esbuild": "^0.24.0",
"fast-glob": "^3.3.2",
"npm-run-all": "^4.1.5",
"rimraf": "^5.0.9",
"rollup": "^4.19.0",
"sass": "^1.77.8",
"vite": "^5.3.4"
"rimraf": "^5.0.10",
"rollup": "^4.24.0",
"sass": "^1.80.3",
"vite": "^5.4.9"
},
"engines": {
"node": ">= 18"
Expand Down
Loading

0 comments on commit 7668cd9

Please sign in to comment.