Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump deps #126

Merged
merged 2 commits into from
Sep 5, 2023
Merged

chore: Bump deps #126

merged 2 commits into from
Sep 5, 2023

Conversation

JorTurFer
Copy link
Contributor

@JorTurFer JorTurFer commented Sep 3, 2023 •
edited
Loading

We want to update this dep within KEDA and for it, we need to bump them here too 😄

Could you cut a release after merging the PR?

@JorTurFer
chore: Bump deps
80880e5 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer mentioned this pull request Sep 3, 2023
Merged
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.32% 🎉

Comparison is base (87e4e2f) 55.29% compared to head (4c5e4a7) 55.61%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   55.29%   55.61%   +0.32%     
==========================================
  Files           1        1              
  Lines         548      552       +4     
==========================================
+ Hits          303      307       +4     
  Misses        181      181              
  Partials       64       64
Flag Coverage Δ
unittests 55.61% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/rotator/rotator.go 55.61% <100.00%> (+0.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JorTurFer
not register namespace if empty
4c5e4a7 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
maxsmythe
maxsmythe approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe requested review from sozercan and ritazh September 5, 2023 16:10
ritazh
ritazh approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer
Copy link
Contributor Author

JorTurFer commented Sep 5, 2023 •
edited
Loading

Could you cut a release with this changes after merging the PR? 🙏

@ritazh ritazh merged commit 2491317 into open-policy-agent:master Sep 5, 2023
@JorTurFer JorTurFer deleted the bump-deps branch September 5, 2023 16:42
@ritazh
Copy link
Member

ritazh commented Sep 5, 2023

https://github.com/open-policy-agent/cert-controller/releases/tag/v0.9.0

@stijndehaes stijndehaes mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsmythe maxsmythe maxsmythe approved these changes

@ritazh ritazh ritazh approved these changes

@sozercan sozercan Awaiting requested review from sozercan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JorTurFer @codecov-commenter @ritazh @maxsmythe