Made restartOnSecretRefresh option part of certrorator #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijndehaes
force-pushed
the
feature/flag-as-option
branch
from
7b1933d to
a0c70d7
Compare
shomron
reviewed
Jan 25, 2021
Instead of relying on people to use the flag parsing mechanism from go. They can pass the option to the CertRotator struct to restart of secret refresh. Signed-off-by: Stijn De Haes <stijndehaes@gmail.com>
stijndehaes
force-pushed
the
feature/flag-as-option
branch
from
a0c70d7 to
6cd430a
Compare
Done! |
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 51.44% 51.31% -0.13%
==========================================
Files 1 1
Lines 381 380 -1
==========================================
- Hits 196 195 -1
Misses 129 129
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
shomron
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on people to use the flag parsing
mechanism from go. They can pass the option to the
CertRotator struct to restart of secret refresh.
Signed-off-by: Stijn De Haes stijndehaes@gmail.com