Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci to v1.38.0 #32

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Bump golangci to v1.38.0 #32

merged 1 commit into from
Apr 13, 2021

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Mar 14, 2021

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 14, 2021 •
edited
Loading

Codecov Report

Merging #32 (2ac93a9) into master (2036247) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   51.74%   51.74%           
=======================================
  Files           1        1           
  Lines         373      373           
=======================================
  Hits          193      193           
  Misses        124      124           
  Partials       56       56
Flag Coverage Δ
unittests 51.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2036247...2ac93a9. Read the comment docs.

@gliptak gliptak changed the title Bump golangci to v2.5.1 Bump golangci to v1.38.0 Mar 14, 2021
@gliptak
Bump golangci to v1.38.0
b402efc 
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@gliptak
Copy link
Contributor Author

gliptak commented Apr 13, 2021

@sozercan anything else you would like to see?

sozercan
sozercan approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, LGTM

@sozercan sozercan requested a review from maxsmythe April 13, 2021 20:58
maxsmythe
maxsmythe approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 9a6f323 into open-policy-agent:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsmythe maxsmythe maxsmythe approved these changes

@sozercan sozercan sozercan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gliptak @codecov-io @sozercan @maxsmythe