Add --group flag to override group name for stdin input #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --group CLI flag to test command for custom group naming - Override FileName from '-' to custom group name when --group is provided - Enables better identification of policy violations in CI/CD workflows - Add unit tests for group flag functionality Fixes open-policy-agent#1095 Signed-off-by: nikos.nikolakakis <nonickedgr@gmail.com>
NoNickeD
force-pushed
the
add-group-flag
branch
from
a39db24 to
9f2b39f
Compare
- Renamed flag from 'group' to 'file-name-override' for clarity - Rewrote tests to use TestRunner.Run() method with proper test fixtures - Added comprehensive acceptance tests for the new flag - Fixed Rego v1 syntax in test policies - Added proper error handling and edge case testing Addresses review feedback from PR open-policy-agent#1163 Signed-off-by: nikos.nikolakakis <nonickedgr@gmail.com>
jalseth
reviewed
Oct 23, 2025
Member
jalseth
left a comment
jalseth
left a comment
There was a problem hiding this comment.
LGTM! Just a couple of minor changes. Thanks for the PR and sorry for the slow review cycle.
runner/test_test.go
Outdated
| defer func() { os.Stdin = oldStdin }() | ||
|
|
||
| // Run the test | ||
| ctx := context.Background() |
runner/test_test.go
Outdated
| } | ||
| }` | ||
| go func() { | ||
| defer w.Close() |
Member
There was a problem hiding this comment.
nit: This defer isn't needed, you can w.Close() after the line below.
runner/test_test.go
Outdated
| Failures: []output.Result{{Message: "test failure"}}, | ||
| }, | ||
| // Run with a regular file (not stdin) | ||
| ctx := context.Background() |
Member
|
@NoNickeD friendly ping. |
- Use t.Context() instead of context.Background() - Remove unnecessary defer in goroutine, call w.Close() directly Signed-off-by: nikos.nikolakakis <nonickedgr@gmail.com>
Member
|
@NoNickeD It looks like the tests are failing. You may need to rebase against the latest changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1095
This PR adds a --group flag to the conftest test command that allows overriding the group name for stdin input.
Problem: When using conftest with kustomize in loops, output shows generic 'FAIL - - main - message' making it hard to identify which component failed.
Solution: Add --group flag to specify custom group name for better traceability.
Usage:
Output:
FAIL - - main - messageFAIL - my/component - main - messageChanges:
Enables better CI/CD traceability and GitHub annotations.