Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module paths to use open-policy-agent #305

Closed

Conversation

tsandall
Copy link
Member

tsandall added 3 commits May 15, 2020 06:29
This is part of
open-policy-agent/opa#2387.

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
Used the following find command arguments:

	find ./docs -type f -name "*.md" -exec  sed -i= s/github\.com\\/instrumenta\\/conftest/github\.com\\/open-policy-agent\\/conftest/g  {} \;

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
…ates

Ran a quick grep to find other instances of
github.com/instrumenta/conftest and these seemed to be the important
ones to update. Note there are still references back to github.com/instrumenta in
but those should be fine. Also, the image repository is still
instrumenta/conftest but we can update those once CI is running.

Signed-off-by: Torin Sandall <torinsandall@gmail.com>
@tsandall
Copy link
Member Author

🌋 📿 let's see what happens!

@tsandall
Copy link
Member Author

It's not clear to me from the circle/acceptance.bats output what went wrong though this line seems likely to have caused it: https://github.com/instrumenta/conftest/blob/d58f240b6dd7f88b07592fa4727455dbe999bd13/acceptance.bats#L277

@jpreese
Copy link
Member

jpreese commented May 15, 2020

@tsandall the command is trying to pull from https://raw.githubusercontent.com/open-policy-agent/conftest/master/examples/compose/policy/deny.rego which (currently returns a 404)

$ conftest test --update https://raw.githubusercontent.com/open-policy-agent/conftest/master/examples/compose/policy/deny.rego examples/compose/docker-compose.yml
Error: update policies: bad response code: 404

This should go away when conftest is actually migrated to the OPA org.

@jpreese
Copy link
Member

jpreese commented May 15, 2020

Just so we're not deadlocked on each other, I'm OK to merge this in whenever you want to make the move official!

@tsandall
Copy link
Member Author

@jpreese excellent! @garethr when you initiate the repo transfer I can accept it.

@garethr
Copy link
Contributor

garethr commented May 16, 2020

I've moved the repo. We can merge this and get testing.

@tsandall
Copy link
Member Author

I'm going to close and reopen this PR to make sure that DCO is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants