Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade: controller-gen v0.5.0, conversion-gen v0.21.0
frameworks/constraint had previously been reliant on an outdated version of the controller-gen library for generating CRDs with embedded JSONSchemas. The older version of the library wasn't built to detect a nested JSONSchema, and thus would not refuse it. With the requirement of v1 CRDs around the corner in k8s 1.22, framework/constraint requires the newer controller-gen v0.5.0. This library version can output v1 CRD. The conversion logic was also in need of a library upgrade, with conversion-gen v0.21.0 now generating the necessary files. This PR _does not_ output a v1 CRD for Constraint Template. That will be left for a future PR. This PR brings the two binaries up-to-date. Note: I attempted to dockerize these two binaries. Controller-gen worked fine, but for some reason conversion-gen couldn't write to the filesystem. The output looked fine, but no dice. Rather than figure out why, I decided to punt on the dockeriziation effort. Signed-off-by: juliankatz <juliankatz@google.com>
- Loading branch information