fix CT name validation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
maxsmythe
reviewed
Jul 2, 2019
| @@ -223,6 +223,9 @@ func (c *client) CreateCRD(ctx context.Context, templ *v1alpha1.ConstraintTempla | |||
| if templ.ObjectMeta.Name != templ.Spec.CRD.Spec.Names.Plural { | |||
There was a problem hiding this comment.
I am split on requiring the plural name == the lower-cased kind (which should equal the singular name).
On the one hand it's an odd requirement. On the other hand it plays well with our convention of appending a version to the name.
One way versioning might change is by giving users control over the group, allowing them to store the version there.
My impulse is to keep what's here b/c tighter requirements can always be loosened. Thoughts?
There was a problem hiding this comment.
keep what's here b/c tighter requirements can always be loosened
Agreed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rita Zhang rita.z.zhang@gmail.com
Fixes open-policy-agent/gatekeeper#156