Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes disable cache flow #369

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Oct 28, 2023

Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3eb381c) 54.06% compared to head (9b34c6f) 54.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   54.06%   54.02%   -0.04%     
==========================================
  Files          67       67              
  Lines        4787     4792       +5     
==========================================
+ Hits         2588     2589       +1     
- Misses       1920     1923       +3     
- Partials      279      280       +1     
Flag Coverage Δ
unittests 54.02% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nilekhc nilekhc marked this pull request as ready for review October 30, 2023 16:27
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 2e0cb3d into open-policy-agent:master Oct 30, 2023
4 checks passed
@nilekhc nilekhc deleted the fix-edrc branch October 30, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External Data function eval failing in 3.14.0-rc.2
4 participants