Skip to content

Commit

Permalink
Change webhook svc from 8443 to webhook-server
Browse files Browse the repository at this point in the history
Update the GKE docs since we use the name webhook-server
you don't have to update the svc targetPort.

Signed-off-by: Edvin Norling <edvin.norling@xenit.se>
  • Loading branch information
Edvin Norling committed Aug 4, 2021
1 parent e94896b commit 6a74339
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 12 deletions.
3 changes: 1 addition & 2 deletions config/webhook/service.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

apiVersion: v1
kind: Service
metadata:
Expand All @@ -7,7 +6,7 @@ metadata:
spec:
ports:
- port: 443
targetPort: 8443
targetPort: webhook-server
selector:
control-plane: controller-manager
gatekeeper.sh/operation: webhook
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
{{- end }}
ports:
- port: 443
targetPort: 8443
targetPort: webhook-server
selector:
app: '{{ template "gatekeeper.name" . }}'
chart: '{{ template "gatekeeper.name" . }}'
Expand Down
2 changes: 1 addition & 1 deletion manifest_staging/deploy/gatekeeper.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,7 @@ metadata:
spec:
ports:
- port: 443
targetPort: 8443
targetPort: webhook-server
selector:
control-plane: controller-manager
gatekeeper.sh/operation: webhook
Expand Down
8 changes: 0 additions & 8 deletions website/docs/cloud-specific.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@ Two ways of working around this:
protocol: TCP
```
- update Gatekeeper service manifest spec:
- update `targetPort` from `8443` to `443`
```yaml
ports:
- port: 443
targetPort: 443
```

## Running on OpenShift 4.x
When running on OpenShift, the `nouid` scc must be used to keep a restricted profile but being able to set the UserID.
Expand Down

0 comments on commit 6a74339

Please sign in to comment.