Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cache status field of constraints #272

Closed
ritazh opened this issue Oct 22, 2019 · 4 comments · Fixed by #313
Closed

Do not cache status field of constraints #272

ritazh opened this issue Oct 22, 2019 · 4 comments · Fixed by #313
Labels
good first issue Good for newcomers

Comments

@ritazh
Copy link
Member

ritazh commented Oct 22, 2019 •
edited
Loading

We are currently caching everything in a constraint in OPA. Let's not cache status since we do not need it for OPA.
@ritazh ritazh added the good first issue Good for newcomers label Oct 22, 2019
@maxsmythe
Copy link
Contributor

The constraint is cached here:

gatekeeper/pkg/controller/constraint/constraint_controller.go

Line 129 in db30921

if _, err := r.opa.AddConstraint(context.Background(), instance); err != nil {

instance is the value of the constraint and is cached directly in OPA.

@tinthud
Copy link

tinthud commented Oct 23, 2019

@maxsmythe @ritazh awesome, thanks! I will have some time tomorrow to look at this one 👍

@maxsmythe
Copy link
Contributor

Thank you!

@EmandM
Copy link
Contributor

EmandM commented Nov 25, 2019

I'm picking this issue up

@EmandM EmandM mentioned this issue Nov 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop caching constraint status to OPA EmandM/gatekeeper
4 participants
@ritazh @EmandM @maxsmythe @tinthud