Stop caching constraint status to OPA #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2019 16:49
Signed-off-by: Emma McMillan <emma.mcmillan@microsoft.com>
maxsmythe
requested changes
Nov 28, 2019
| func (r *ReconcileConstraint) cacheConstraint(instance *unstructured.Unstructured) error { | ||
| obj := instance.DeepCopy() | ||
| // Remove the status field since we do not need it for OPA | ||
| unstructured.RemoveNestedField(obj.Object, "status", "byPod") |
There was a problem hiding this comment.
We can remove all of status
Signed-off-by: Emma McMillan <emma.mcmillan@microsoft.com>
ritazh
reviewed
Nov 28, 2019
| @@ -127,7 +127,7 @@ func (r *ReconcileConstraint) Reconcile(request reconcile.Request) (reconcile.Re | |||
| if err = util.SetHAStatus(instance, status); err != nil { | |||
| return reconcile.Result{}, err | |||
| } | |||
| if _, err := r.opa.AddConstraint(context.Background(), instance); err != nil { | |||
| if err := r.cacheConstraint(instance); err != nil { | |||
There was a problem hiding this comment.
I don't think err needs to be instantiated here. linter should have caught this.
There was a problem hiding this comment.
Doesn't need to be but valid if it is. If instantiated it avoids clobbering whatever err was in the outer scope.
Does linter complain when you run it locally?
There was a problem hiding this comment.
No complaints when run locally for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Emma McMillan emma.mcmillan@microsoft.com
Fixes #272