Deduplicate mutator controller logic #1474
Conversation
maxsmythe
changed the title
maxsmythe
force-pushed
the
dedupe-mutators
branch
2 times, most recently
from
7a22df5 to
b028142
Compare
| kind := "Assign" | ||
| newObj := func() client.Object { return &mutationsv1alpha1.Assign{} } | ||
| newMutator := func(obj client.Object) (types.Mutator, error) { | ||
| assign := obj.(*mutationsv1alpha1.Assign) |
There was a problem hiding this comment.
Disabled linting. I think we want to panic, which will expose type mismatches during testing.
| } | ||
|
|
||
| // Reconciler reconciles mutator objects. | ||
| type Reconciler struct { |
There was a problem hiding this comment.
Might be nice for Reconciler type declaration to be above newReconciler() in the code, for readability
There was a problem hiding this comment.
Depends on what you're looking for. If you want to know "how do I add a reconciler", it's better to have the newReconciler at the top, as consumers of this generally don't care how the reconciler is implemented.
The current order of things sticks as closely to the kubebuilder generated output as we can, which hopefully makes the code more readable to those with that context.
| tracker *readiness.Tracker, | ||
| getPod func() (*corev1.Pod, error), | ||
| kind string, | ||
| newObj func() client.Object, |
There was a problem hiding this comment.
A more descriptive name could be nice here. Something like mutationType. newMutator could be MutatorFor or something like that.
There was a problem hiding this comment.
I workshopped some names, let me know what you think
maxsmythe
force-pushed
the
dedupe-mutators
branch
from
b028142 to
f18e7af
Compare
|
@ritazh @julianKatz addressed comments and pushed changes. |
maxsmythe
force-pushed
the
dedupe-mutators
branch
from
f18e7af to
1f9f71b
Compare
| GetPod: a.GetPod, | ||
| MutationSystem: a.MutationSystem, | ||
| Kind: "Assign", | ||
| NewMutationObj: func() client.Object { return &mutationsv1alpha1.Assign{} }, |
|
LGTY @ritazh ? |
Fixes open-policy-agent#1449 Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe
force-pushed
the
dedupe-mutators
branch
from
1f9f71b to
8aa72b3
Compare
Fixes #1449
Signed-off-by: Max Smythe smythe@google.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: