-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exempt-namespace-prefix to helm chart #1523
add exempt-namespace-prefix to helm chart #1523
Conversation
@wolffberg Thank you for the PR! Can you please fix the failing DCO check? (instructions are in the Details link) |
Ah sorry, missed that one. All done 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #1523 +/- ##
==========================================
+ Coverage 51.86% 51.90% +0.03%
==========================================
Files 86 86
Lines 7812 7812
==========================================
+ Hits 4052 4055 +3
+ Misses 3404 3402 -2
+ Partials 356 355 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pls rerun make manifests
then checkin all the changes in manifest_staging? thank you!
Signed-off-by: David Wolffberg <1350533+wolffberg@users.noreply.github.com>
Done |
What this PR does / why we need it:
This PR is going to add support for setting
exempt-namespace-prefix
arguments to the deployment ofgatekeeper-controller-manager
from the values YAML file.Special notes for your reviewer: