Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exempt-namespace-prefix to helm chart #1523

Merged
merged 2 commits into from
Sep 9, 2021
Merged

add exempt-namespace-prefix to helm chart #1523

merged 2 commits into from
Sep 9, 2021

Conversation

wolffberg
Copy link
Contributor

What this PR does / why we need it:
This PR is going to add support for setting exempt-namespace-prefix arguments to the deployment of gatekeeper-controller-manager from the values YAML file.

Special notes for your reviewer:

@ritazh
Copy link
Member

ritazh commented Aug 31, 2021

@wolffberg Thank you for the PR! Can you please fix the failing DCO check? (instructions are in the Details link)

@wolffberg
Copy link
Contributor Author

Ah sorry, missed that one. All done 🎉

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #1523 (b4e453e) into master (c91112c) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
+ Coverage   51.86%   51.90%   +0.03%     
==========================================
  Files          86       86              
  Lines        7812     7812              
==========================================
+ Hits         4052     4055       +3     
+ Misses       3404     3402       -2     
+ Partials      356      355       -1     
Flag Coverage Δ
unittests 51.90% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 55.50% <0.00%> (ø)
pkg/controller/mutators/core/controller_core.go 55.44% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91112c...b4e453e. Read the comment docs.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls rerun make manifests then checkin all the changes in manifest_staging? thank you!

Signed-off-by: David Wolffberg <1350533+wolffberg@users.noreply.github.com>
@wolffberg
Copy link
Contributor Author

Done

@ritazh ritazh merged commit 426b4f4 into open-policy-agent:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants