[gator test] Support referential constraints #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbeason
added
the
authorship-tooling
willbeason
force-pushed
the
referential-constraints
branch
from
5b27600 to
98d1b6b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
+ Coverage 53.67% 54.03% +0.36%
==========================================
Files 93 93
Lines 7995 8080 +85
==========================================
+ Hits 4291 4366 +75
- Misses 3364 3371 +7
- Partials 340 343 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbeason
force-pushed
the
referential-constraints
branch
2 times, most recently
from
2eb0ea4 to
0d01cac
Compare
Could you fill out the rest of the description? |
Done. |
julianKatz
approved these changes
Sep 28, 2021
willbeason
force-pushed
the
referential-constraints
branch
2 times, most recently
from
4519e76 to
380ba92
Compare
added 6 commits
September 29, 2021 13:03
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
This reduces test runtime from 7s to ~0.8s on my machine. Block usage of ToVersionless() behind mutex since it isn't yet threadsafe. Allow caller to pass scheme into test runner. This makes the test runner more extensible and prevents tests which need to manipulate scheme from having data races. Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Make Test.Cases a slice of pointers to avoid copying. Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
willbeason
force-pushed
the
referential-constraints
branch
from
380ba92 to
9de100e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
gator testfor referential constraints.To keep tests hermetic, we now instantiate a new OPA client for each test case. Otherwise, we risk crosstalk between tests if resetting Data in the OPA client fails.
Other minor changes: