Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to golangci-lint v1.42.1 #1579

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

willbeason
Copy link
Member

Upgrade to the most recent version and fix linter errors.

Signed-off-by: Will Beason willbeason@google.com

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #1579 (d796cf8) into master (7ea3783) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
+ Coverage   53.77%   53.84%   +0.07%     
==========================================
  Files          93       93              
  Lines        7995     7995              
==========================================
+ Hits         4299     4305       +6     
+ Misses       3356     3351       -5     
+ Partials      340      339       -1     
Flag Coverage Δ
unittests 53.84% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/object_tracker.go 82.41% <0.00%> (-1.10%) ⬇️
pkg/readiness/ready_tracker.go 69.82% <0.00%> (-0.57%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 58.47% <0.00%> (+0.95%) ⬆️
pkg/watch/replay.go 81.25% <0.00%> (+2.27%) ⬆️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea3783...d796cf8. Read the comment docs.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@julianKatz julianKatz self-requested a review September 28, 2021 19:44
@julianKatz
Copy link
Contributor

julianKatz commented Sep 28, 2021

@willbeason Please also update the Makefile. After that, LGTM

Will Beason added 3 commits September 28, 2021 13:17
Upgrade to the most recent version and fix linter errors.

Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willbeason willbeason merged commit 0b663ca into open-policy-agent:master Sep 29, 2021
@willbeason willbeason deleted the upgrade-golangci branch September 29, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants