-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enforcementAction to status #180
Add enforcementAction to status #180
Conversation
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nits
LGTM. 'violations' instead of 'violationsByAction' (like we agreed to the other day) makes sense to me given that the value is an array of objects. It's clean that the enforcementaction is just another field. |
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…agent#185) * Add violationByAction to status Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> * Revert to violations Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Cameron McCarthy <camm@google.com>
ref: https://issues.redhat.com/browse/ACM-6233 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> Co-authored-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
ref: https://issues.redhat.com/browse/ACM-6233 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> Co-authored-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> Signed-off-by: Yi Rae Kim <yikim@redhat.com>
Signed-off-by: Rita Zhang rita.z.zhang@gmail.com
@timothyhinrichs @maxsmythe
Per our discussion for the Dry Run design proposal, this PR updates the status field of Constraint object to include the
enforcementAction
the violation resulted from.Example of a Constraint's status field as a result of this PR:
Once we have implemented the dry run feature, it could be something like:
Constraint for prod
Constraint for dev