Make logging configurable #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
requested changes
Aug 20, 2019
maxsmythe
reviewed
Aug 21, 2019
cmd/manager/main.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| logLevel = flag.String("log-level", "INFO", "Minimum log level") |
There was a problem hiding this comment.
List all the options in the help text.
|
actually, one doc nit |
|
LGTM |
maxsmythe
approved these changes
Aug 21, 2019
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rita Zhang rita.z.zhang@gmail.com
fixes #210
NOTE:
logf.ZapLogger(false)sets the log level at INFO level.