-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add audit_last_run_end_time metric #2235
feat: add audit_last_run_end_time metric #2235
Conversation
I haven't touched versioned website docs – not sure if they should be updated yet. |
Codecov Report
@@ Coverage Diff @@
## master #2235 +/- ##
==========================================
+ Coverage 54.34% 54.52% +0.18%
==========================================
Files 111 111
Lines 9538 9553 +15
==========================================
+ Hits 5183 5209 +26
+ Misses 3954 3948 -6
+ Partials 401 396 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
You don't need to update the versioned website docs since this update will only be available after v3.10 is released. |
@ritazh it might make sense to update versioned docs to update description of |
4a0bdc2
to
b5acc5b
Compare
@ritazh I've updated description in older versioned docs, but I can remove those changes if you'd prefer me to |
b5acc5b
to
8373b28
Compare
Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
clarify gatekeeper_audit_last_run_time metric description in versioned website docs Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
8373b28
to
45eaac1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
It adds a new metric to track last finishing time for audit runs, to ensure that audit runs do actually finish.
It also updates description of existing metric to note that it only shows time when audit has started, and not when audit has finished.
See #2197 for more info.